Instead of listing special characters in re, '?' is excluded #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shoubamzlibap I hadn't the time to test this. Have you tested this further? In which case the builtin regex fails? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The re_static_file should identify static files in URLS. To my understanding the main goal is to seperate the filename from the query string (seperated by '?'). The current solution lists a couple of special characters that might occur in filenames, but is not complete by far.
Instead of listing all possible special characters that might occur in filenames (especially user generated ones), this version of re_static_file only excludes the question mark, which would sperate the filename from the query string.